Skip to content

TST: add messages to bare pytest raises #38414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marktgraham
Copy link
Contributor

@marktgraham marktgraham commented Dec 11, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This PR adds messages to the bare pytest raises in pandas/tests/generic/methods/test_pipe.py and pandas/tests/reshape/merge/test_merge_asof.py. This PR references #30999.

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messages don't seem to match in test_valid_join_keys, test_valid_tolerance

@jreback jreback added the Error Reporting Incorrect or improved errors from pandas label Dec 14, 2020
@jreback jreback added this to the 1.3 milestone Dec 14, 2020
@jreback jreback merged commit 7dccda5 into pandas-dev:master Dec 14, 2020
@jreback
Copy link
Contributor

jreback commented Dec 14, 2020

thanks @marktgraham nice!

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants