Skip to content

BUG: Don't cast nullable Boolean to float in groupby #33089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonjayhawkins merged 18 commits into from
Apr 7, 2020
+39 −9
Merged

BUG: Don't cast nullable Boolean to float in groupby #33089

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5f8477f
Don't check isinstance
dsaxton Mar 28, 2020
359231c
Fix categorical test
dsaxton Mar 28, 2020
5311de9
Take out len
dsaxton Mar 28, 2020
0aa91f6
Special case categorical
dsaxton Mar 28, 2020
8546e29
Tests
dsaxton Mar 28, 2020
cf29e31
Revert "Fix categorical test"
dsaxton Mar 28, 2020
62de835
Note
dsaxton Mar 28, 2020
89505ac
Hack test
dsaxton Mar 28, 2020
a426f9d
Black
dsaxton Mar 28, 2020
85fe250
Add tests
dsaxton Mar 28, 2020
d55a74f
Include dict case
dsaxton Mar 28, 2020
c7e38b0
Issue numbers
dsaxton Mar 28, 2020
58b2ba4
Merge remote-tracking branch 'upstream/master' into result-casting
dsaxton Mar 28, 2020
a4e10b6
Merge remote-tracking branch 'upstream/master' into result-casting
dsaxton Mar 29, 2020
fc25876
Move note
dsaxton Mar 29, 2020
db4fb5e
Update tests
dsaxton Mar 29, 2020
34cb8d6
Merge remote-tracking branch 'upstream/master' into result-casting
dsaxton Mar 30, 2020
e55a0d4
Merge remote-tracking branch 'upstream/master' into result-casting
dsaxton Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'upstream/master' into result-casting
  • Loading branch information
@dsaxton
dsaxton committed Apr 7, 2020
commit e55a0d463def16ae3a5f14bc2ca6606c000a59d2
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v1.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ Groupby/resample/rolling
- Bug in :meth:`DataFrame.groupby` and :meth:`Series.groupby` produces inconsistent type when aggregating Boolean series (:issue:`32894`)
- Bug in :meth:`SeriesGroupBy.first`, :meth:`SeriesGroupBy.last`, :meth:`SeriesGroupBy.min`, and :meth:`SeriesGroupBy.max` returning floats when applied to nullable Booleans (:issue:`33071`)
- Bug in :meth:`DataFrameGroupBy.agg` with dictionary input losing ``ExtensionArray`` dtypes (:issue:`32194`)

- Bug in :meth:`DataFrame.resample` where an ``AmbiguousTimeError`` would be raised when the resulting timezone aware :class:`DatetimeIndex` had a DST transition at midnight (:issue:`25758`)

Reshaping
^^^^^^^^^
Expand Down Expand Up @@ -479,6 +479,7 @@ Sparse
ExtensionArray
^^^^^^^^^^^^^^

- Fixed bug where :meth:`Serires.value_counts` would raise on empty input of ``Int64`` dtype (:issue:`33317`)
-


Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.