CLN: catch less in groupby #29077
Merged
CLN: catch less in groupby #29077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # raised directly by _aggregate_multiple_funcs | ||
| pass | ||
| elif "decimal does not support skipna=True" in str(err): | ||
| # FIXME: kludge for DecimalArray tests |
There was a problem hiding this comment.
What is the end goal of this change?
I don't think we should have special cases in the code for our tests?
There was a problem hiding this comment.
The upcoming fix here is to have DecimalArray._reduce implement support skipna=True.
A lot of spaghetti code here is driven by the numeric_only behavior that suppresses exceptions.
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second place where the DecimalArray case has popped up, will move to fix that before too long.