Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Bump Cython to 0.29.13 #28391

Merged
merged 6 commits into from
Sep 12, 2019
Merged

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Sep 11, 2019

In preperation for Python 3.8, we need to ensure we compile the sdist
with new enough versions of Cython. This is the latest current release.

xref #28341

In preperation for Python 3.8, we need to ensure we compile the sdist
with new enough versions of Cython. This is the latest current release.
@TomAugspurger TomAugspurger added the Build Library building on various platforms label Sep 11, 2019
@TomAugspurger TomAugspurger added this to the 0.25.2 milestone Sep 11, 2019
@TomAugspurger
Copy link
Contributor Author

Just the SSL doc build issue causing the failure.

@jbrockmendel
Copy link
Member

LGTM. is the SSL thing something we can suppress for a day?

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Sep 11, 2019 via email

@jreback jreback merged commit b3bd4df into pandas-dev:master Sep 12, 2019
@jreback
Copy link
Contributor

jreback commented Sep 12, 2019

thanks @TomAugspurger

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 12, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 0.25.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 b3bd4dfc855732c81de1019090fe4bc9b7354788
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #28391: DEP: Bump Cython to 0.29.13'
  1. Push to a named branch :
git push YOURFORK 0.25.x:auto-backport-of-pr-28391-on-0.25.x
  1. Create a PR against branch 0.25.x, I would have named this PR:

"Backport PR #28391 on branch 0.25.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@TomAugspurger
Copy link
Contributor Author

I'll do the backport.

@TomAugspurger TomAugspurger deleted the bump-cython branch September 12, 2019 12:54
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Sep 12, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants