CLN: Misc Python 2 references #26085
Conversation
| except AttributeError: | ||
| # source compatibility with Py2. | ||
| na_value = {} | ||
| na_value = UserDict() |
There was a problem hiding this comment.
can this just be a dict or OrderedDict?
There was a problem hiding this comment.
From this comment in same file, using UserDict is intentional in order to treat dict as a scalar.
We currently store lists of UserDicts. Pandas has a few places
internally that specifically check for dicts, and does non-scalar things
in that case. We want the dictionaries to be treated as scalars, so we
hack around pandas by using UserDicts.
Codecov Report
@@ Coverage Diff @@
## master #26085 +/- ##
==========================================
- Coverage 40.88% 40.76% -0.13%
==========================================
Files 175 175
Lines 52443 52434 -9
==========================================
- Hits 21443 21373 -70
- Misses 31000 31061 +61
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26085 +/- ##
==========================================
+ Coverage 91.95% 91.95% +<.01%
==========================================
Files 175 175
Lines 52443 52433 -10
==========================================
- Hits 48224 48217 -7
+ Misses 4219 4216 -3
Continue to review full report at Codecov.
|
|
thanks @mroeschke |
git diff upstream/master -u -- "*.py" | flake8 --diffThe notable change here is removing the SIX license since I think we've removed any borrowed compatibility code.