Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#26065 Fix Type Annotations in pandas.core.arrays #26071

Merged
merged 11 commits into from
Apr 30, 2019
Merged

#26065 Fix Type Annotations in pandas.core.arrays #26071

merged 11 commits into from
Apr 30, 2019

Conversation

gwrome
Copy link
Contributor

@gwrome gwrome commented Apr 12, 2019

gwrome
gwrome commented Apr 12, 2019
View reviewed changes
pandas/core/arrays/period.py Outdated Show resolved Hide resolved
gwrome
gwrome commented Apr 12, 2019
View reviewed changes
pandas/core/arrays/period.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #26071 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26071      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52509    52513       +4     
==========================================
  Hits        48255    48255              
- Misses       4254     4258       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 40.75% <85.71%> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 97.69% <100%> (ø) ⬆️
pandas/core/arrays/interval.py 93.12% <100%> (ø) ⬆️
pandas/core/arrays/integer.py 96.34% <100%> (+0.01%) ⬆️
pandas/core/arrays/timedeltas.py 88.29% <100%> (+0.02%) ⬆️
pandas/core/arrays/period.py 98.54% <100%> (ø) ⬆️
pandas/core/arrays/array_.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15069...b39f7fc. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 12, 2019 •
edited
Loading

Codecov Report

Merging #26071 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26071      +/-   ##
==========================================
- Coverage   91.97%   91.96%   -0.01%     
==========================================
  Files         175      175              
  Lines       52368    52378      +10     
==========================================
+ Hits        48164    48170       +6     
- Misses       4204     4208       +4
Flag Coverage Δ
#multiple 90.52% <100%> (ø) ⬆️
#single 40.7% <73.33%> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 97.71% <100%> (+0.01%) ⬆️
pandas/core/arrays/integer.py 96.35% <100%> (+0.01%) ⬆️
pandas/core/arrays/interval.py 93.06% <100%> (ø) ⬆️
pandas/_typing.py 100% <100%> (ø) ⬆️
pandas/core/arrays/timedeltas.py 88.61% <100%> (+0.02%) ⬆️
pandas/core/arrays/period.py 98.53% <100%> (ø) ⬆️
pandas/core/arrays/array_.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feb3ad...5f840e9. Read the comment docs.

@jschendel jschendel added the Typing type annotations, mypy/pyright type checking label Apr 13, 2019
WillAyd
WillAyd requested changes Apr 14, 2019
View reviewed changes
pandas/core/arrays/array_.py Show resolved Hide resolved
pandas/core/arrays/datetimelike.py Outdated Show resolved Hide resolved
pandas/core/arrays/datetimelike.py Outdated Show resolved Hide resolved
pandas/core/arrays/interval.py Outdated Show resolved Hide resolved
WillAyd
WillAyd requested changes Apr 22, 2019
View reviewed changes
pandas/core/dtypes/dtypes.py Outdated Show resolved Hide resolved
pandas/core/arrays/datetimelike.py Show resolved Hide resolved
@WillAyd WillAyd mentioned this pull request Apr 23, 2019
Merged
4 tasks
@WillAyd
Copy link
Member

WillAyd commented Apr 25, 2019

@gwrome can you merge master?

jreback
jreback requested changes Apr 26, 2019
View reviewed changes
pandas/_typing.py Outdated Show resolved Hide resolved
WillAyd
WillAyd approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm outside of comment from @jreback

Some of the cast stuff is unfortunate but not sure there is a way to get around that given limitations cited.

@jreback jreback added this to the 0.25.0 milestone Apr 28, 2019
jreback
jreback requested changes Apr 28, 2019
View reviewed changes
pandas/core/arrays/datetimelike.py Outdated Show resolved Hide resolved
pandas/core/arrays/interval.py Outdated Show resolved Hide resolved
pandas/core/arrays/period.py Outdated Show resolved Hide resolved
pandas/core/arrays/period.py Show resolved Hide resolved
@jreback jreback merged commit f54945e into pandas-dev:master Apr 30, 2019
@jreback
Copy link
Contributor

jreback commented Apr 30, 2019

thanks @gwrome

@gwrome gwrome deleted the blacklist-arrays branch April 30, 2019 19:32
@gwrome gwrome mentioned this pull request May 6, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Fix Type Annotations in pandas.core.arrays
5 participants
@gwrome @WillAyd @jreback @jbrockmendel @jschendel