TYP: Replace wildcardimports in toplevelinit as precursor for reshape,stata,io PRs #25936 #25940 #25939

[ryankarlos]

• xref Remove pandas.io.stata from Typing Blacklist #25932, Assorted Typing Fixups in pandas.io #25933, Assorted Typing Fixups in pandas.core.reshape #25934
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[ryankarlos]

@WillAyd Since im working on PRs #25936 #25940 #25939 which all depend on this top level import - thought it would make sense to replace wildcard imports for stata, reshape and io modules at the same time.

[WillAyd]

I think you can still import from the apis exposed by each package but just need to list out the object that you are pulling in. Does that no work with Mypy?

[ryankarlos]

So the only error that mypy throws is this -
pandas/__init__.py:70: error: Module 'pandas._libs' has no attribute 'join'

Theres a lot of other modules in those apis which do not particularly affect the reshape, stata PRs that i am working on but Ive I've included them in in case they need to be imported via top level from other modules in the future.

[jreback]

this must be very precisely done, IOW importing names explicity as we have tests which exactly guaranteee these imports are no more and no less what is actually imported

[codecov]

Codecov Report

Merging #26019 into master will decrease coverage by 51.1%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #26019       +/-   ##
===========================================
- Coverage   91.82%   40.72%   -51.11%     
===========================================
  Files         175      175               
  Lines       52536    52536               
===========================================
- Hits        48243    21397    -26846     
- Misses       4293    31139    +26846

Flag	Coverage Δ
#multiple	?
#single	40.72% <ø> (-0.14%)	⬇️

Impacted Files	Coverage Δ
pandas/io/formats/latex.py	0% <0%> (-100%)	⬇️
pandas/io/sas/sas_constants.py	0% <0%> (-100%)	⬇️
pandas/core/groupby/categorical.py	0% <0%> (-100%)	⬇️
pandas/tseries/plotting.py	0% <0%> (-100%)	⬇️
pandas/tseries/converter.py	0% <0%> (-100%)	⬇️
pandas/io/formats/html.py	0% <0%> (-99.37%)	⬇️
pandas/io/sas/sas7bdat.py	0% <0%> (-91.16%)	⬇️
pandas/io/sas/sas_xport.py	0% <0%> (-90.1%)	⬇️
pandas/core/tools/numeric.py	10.44% <0%> (-89.56%)	⬇️
pandas/io/s3.py	0% <0%> (-89.48%)	⬇️
... and 130 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f9228...7aa943b. Read the comment docs.

[codecov]

Codecov Report

Merging #26019 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26019      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.01%     
==========================================
  Files         175      175              
  Lines       52517    52517              
==========================================
- Hits        48233    48228       -5     
- Misses       4284     4289       +5

Flag	Coverage Δ
#multiple	90.39% <ø> (ø)	⬆️
#single	40.72% <ø> (-0.13%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	75% <0%> (-12.5%)	⬇️
pandas/core/frame.py	96.79% <0%> (-0.12%)	⬇️
pandas/util/testing.py	90.62% <0%> (-0.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6b90a...f519a03. Read the comment docs.

[ryankarlos]

@jreback @WillAyd Thanks for the reviews, i've pushed latest changes - all green now.

[WillAyd]

Looks like there is still one wildcard import for NumPy compat - can you take a look at that here?

[jreback]

can you organize these by section, e.g. something like

from pandas.core.api import (
    # dtype
    Int8Dtype.........

   # indexes
    Int64Index.....

  # tseries
   NaT, Period.....

  # conversion
   to_numeric, to_datetime...

  # missing
   isna, isnul.....

  # misc
  np, TimeGrouper....

[jreback]

can you sort these

[pep8speaks]

Hello @ryankarlos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-10 00:38:29 UTC

[ryankarlos]

@jreback @WillAyd pushed latest changes through

[jreback]

thanks @ryankarlos

[jreback]

if you’d merge master and update any typing PRs can get them in

[ryankarlos]

Thanks @jreback , pushed latest updates for dependant PRs #25936 #25940 #25939