-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: Fix maybe_promote #25425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
REF: Fix maybe_promote #25425
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
bf05e4c
TST: add test coverage for maybe_promote
h-vetinari 60889ea
REF: refactor and fix maybe_promote
h-vetinari 6792a54
Fix remaining failures
h-vetinari c6043cb
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari 8d9a3b7
Forgot to flake
h-vetinari b903d2e
Another try at int2int...
h-vetinari 91e6673
Last one?
h-vetinari 1a9d6a1
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari c0a3a4e
Review (jbrockmendel)
h-vetinari 2d3a3ba
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari ce0efda
lint
h-vetinari e67dd99
reduce diff
h-vetinari 7cec643
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari 321f08d
review (jbrockmendel)
h-vetinari 5c5e0f1
fix isort
h-vetinari bfb8a2f
fix docstring example
h-vetinari 088787e
remove unicode from possible returns of infer_dtype
h-vetinari bf12d67
perf: only compute max if necessary
h-vetinari d9bbf07
update comment
h-vetinari 0f1ff5f
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari 076926e
format with black
h-vetinari 06e22a3
remove usage of deprecated .real/.imag
h-vetinari 0f8f064
lint
h-vetinari 98c584e
work around GH 27610
h-vetinari 231d8a6
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari 2fa6831
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari 1cbd5c0
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari 32d8a2b
Review (jbrockmendel)
h-vetinari 2a8691a
minor comment improvements/cleanups
h-vetinari d5aa77b
exploration: check if array-case is required
h-vetinari fa347b6
Revert "exploration: check if array-case is required"
h-vetinari 8aab981
A painful merge
h-vetinari 82ec973
adapt array-path to new test behaviour
h-vetinari 3c5c3e0
Merge remote-tracking branch 'upstream/master' into fix_maybe_promote
h-vetinari b5eb1c4
lint: isort
h-vetinari 3976220
catch irrelevant warning
h-vetinari b8cd4f0
fix outdated iNaT-documentation
h-vetinari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
TST: add test coverage for maybe_promote
- Loading branch information
commit bf05e4c9ffe27459fffcc7471dce2e7b51e89b81
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.