Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix DataFrame.astype(ExtensionDtype) with duplicate column names #24717

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

jschendel
Copy link
Member

@jschendel jschendel added Bug Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 11, 2019
@jschendel jschendel added this to the 0.24.0 milestone Jan 11, 2019
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #24717 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24717   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52321    52321           
=======================================
  Hits        48337    48337           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46d2a5...84e6033. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #24717 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24717   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52321    52321           
=======================================
  Hits        48337    48337           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46d2a5...84e6033. Read the comment docs.

@jreback jreback merged commit e2b2068 into pandas-dev:master Jan 11, 2019
@jreback
Copy link
Contributor

jreback commented Jan 11, 2019

thanks @jschendel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants