Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Making explicit when we run the db tests #24450

Merged
merged 7 commits into from
Dec 29, 2018
Merged

TST: Making explicit when we run the db tests #24450

merged 7 commits into from
Dec 29, 2018

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista added Testing pandas testing functions or related to the test suite IO SQL to_sql, read_sql, read_sql_query CI Continuous Integration labels Dec 27, 2018
@datapythonista datapythonista changed the title WIP: Making explicity when we run the db tests WIP: Making explicit when we run the db tests Dec 27, 2018
@jreback
Copy link
Contributor

jreback commented Dec 27, 2018

you need to leave the skips if not installed

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #24450 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24450   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51987    51987           
=======================================
  Hits        47989    47989           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.72% <0%> (ø) ⬆️
#single 43% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c920e...36406be. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #24450 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24450   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51987    51987           
=======================================
  Hits        47989    47989           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.72% <0%> (ø) ⬆️
#single 43% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c920e...36406be. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #24450 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24450   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51987    51987           
=======================================
  Hits        47989    47989           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.72% <0%> (ø) ⬆️
#single 43% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c920e...36406be. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #24450 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24450   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51987    51987           
=======================================
  Hits        47989    47989           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.72% <0%> (ø) ⬆️
#single 43% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c920e...36406be. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #24450 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24450   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51987    51987           
=======================================
  Hits        47989    47989           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.72% <0%> (ø) ⬆️
#single 43% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c920e...36406be. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 27, 2018 •
edited
Loading

Codecov Report

Merging #24450 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24450   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         163      163           
  Lines       51948    51948           
=======================================
  Hits        47945    47945           
  Misses       4003     4003
Flag Coverage Δ
#multiple 90.7% <0%> (ø) ⬆️
#single 42.99% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab55d05...6eb3d27. Read the comment docs.

@datapythonista
Copy link
Member Author

I was checking that no errors happened when tests were not skipped unless explicitly. All was green, added the skips now.

@datapythonista datapythonista changed the title WIP: Making explicit when we run the db tests TST: Making explicit when we run the db tests Dec 28, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 28, 2018
@jreback
Copy link
Contributor

jreback commented Dec 28, 2018

lgtm. can you just do a import pandas; pandas.test() to make sure properly skipping when libraries are not installed. I believe we test this in the CI as well.

@datapythonista
Copy link
Member Author

pandas.test() is also skipping the tests

pandas/tests/io/test_sql.py ....................................................................................................s....sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 66%]
sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss...ssssssssssssssssssssssssssssssssssss.................s.............ssssssssss                                                        [ 66%]

@jreback jreback merged commit 80295f9 into pandas-dev:master Dec 29, 2018
@jreback
Copy link
Contributor

jreback commented Dec 29, 2018

thanks!

@datapythonista datapythonista mentioned this pull request Dec 30, 2018
Merged
1 task
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@datapythonista @Pingviinituutti
TST: Making explicit when we run the db tests (pandas-dev#24450)
b369e5d
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@datapythonista @Pingviinituutti
TST: Making explicit when we run the db tests (pandas-dev#24450)
d154650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

TST: Run tests using a database explicitly
2 participants
@datapythonista @jreback