Skip to content

Split fastpath IntegerArray constructor and general purpose constructor #22070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 20, 2018
Merged

Split fastpath IntegerArray constructor and general purpose constructor #22070

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0ea2f1
Split fastpath IntegerArray constructor and general purpose constructor
jorisvandenbossche Jul 26, 2018
c5de1f2
some docs and tests
jorisvandenbossche Jul 28, 2018
5e8c1a4
fix test for 32 bit
jorisvandenbossche Jul 29, 2018
90a9c13
add dtype tests
jorisvandenbossche Jul 29, 2018
2fc70e1
ensure output is always int64 for all platforms if values have no int…
jorisvandenbossche Jul 29, 2018
3738d1c
Merge remote-tracking branch 'upstream/master' into integer-array-con…
jorisvandenbossche Aug 14, 2018
5948ae5
specify dtype in _from_sequence where needed
jorisvandenbossche Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add dtype tests
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jul 29, 2018
commit 90a9c131109b1b9e5eea05ba8bbafdd0ee5190c6
21 changes: 21 additions & 0 deletions pandas/tests/extension/integer/test_integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,27 @@ def test_to_integer_array_error(values):
integer_array(values)


def test_to_integer_array_inferred_dtype():
# if values has dtype -> respect it
result = integer_array(np.array([1, 2], dtype='int8'))
assert result.dtype == Int8Dtype()
result = integer_array(np.array([1, 2], dtype='int32'))
assert result.dtype == Int32Dtype()

# if values have no dtype -> always int64
result = integer_array([1, 2])
assert result.dtype == Int64Dtype()


def test_to_integer_array_dtype_keyword():
result = integer_array([1, 2], dtype='int8')
assert result.dtype == Int8Dtype()

# if values has dtype -> override it
result = integer_array(np.array([1, 2], dtype='int8'), dtype='int32')
assert result.dtype == Int32Dtype()


def test_to_integer_array_float():
result = integer_array([1., 2.])
expected = integer_array(np.array([1, 2], dtype='int64'))
Expand Down