-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLN] Dispatch (some) Frame ops to Series, avoiding _data.eval #22019
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
5195dad
avoid casting to object dtype in mixed-type frames
jbrockmendel 1a66906
Dispatch to Series ops in _combine_match_columns
jbrockmendel a45abec
comment
jbrockmendel 8594c48
docstring
jbrockmendel 108550e
flake8 fixup
jbrockmendel 07fb477
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 946e54a
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 323f45e
dont bother with try_cast_result
jbrockmendel b3cedf1
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel a0708d1
revert non-central change
jbrockmendel 5d3db89
simplify
jbrockmendel aa41de3
revert try_cast_results
jbrockmendel 01c3720
revert non-central changes
jbrockmendel bcb6735
Fixup typo syntaxerror
jbrockmendel b3ef417
simplify assertion
jbrockmendel 4b2e21a
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 330a94a
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 4c4f626
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 757e2ae
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel ff96c0d
use dispatch_to_series in combine_match_columns
jbrockmendel 17f33b6
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel c30f898
Pass unwrapped op where appropriate
jbrockmendel 82a7928
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 52b7102
catch correct error
jbrockmendel 453ae8e
whatsnew note
jbrockmendel 93887cf
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel dd115c8
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 265ec78
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel db5ca89
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel f574c24
comment
jbrockmendel e6821a2
whatsnew section
jbrockmendel da2e32c
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel a6a7f58
remove unnecessary tester
jbrockmendel b21a8a2
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 858165f
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 31d4089
Merge branch 'master' of https://github.com/pandas-dev/pandas into mops2
jbrockmendel 5832c2b
doc fixup
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docstring
- Loading branch information
commit 8594c48051ff5992a6e5ef9f5386fc66ae772aaf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IF you need this function, it should be in panda/core/dtypes/cast.py. I say IF because this looks like lots of other functions there. please see if you can simplify. we want to remove things from internals not add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, though I'm hoping we can get rid of it before long.
This is based on the existing
Block._try_cast_result
, which is changed to just call this function.Very much so. The point of this PR (along with another branch in progress) is to remove
Block.eval
andBlockManager.eval
. (and in doing so ensure that Series/DataFrame ops all agree)