Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix versionadded directive typos in IntervalIndex #21649

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

jschendel
Copy link
Member

There needs to be a space between the .. and versionadded::. Currently being rendered as plaintext, which doesn't look too great:

image

Couldn't find any other instances of this in the codebase for versionadded or any other commonly used directives. Pretty minor so tagging this as 0.23.2.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure - merge away (and add backport label)

maybe worth trying to catch this in lint.sh ?

@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #21649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21649   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         154      154           
  Lines       49558    49558           
=======================================
  Hits        45545    45545           
  Misses       4013     4013
Flag Coverage Δ
#multiple 90.27% <ø> (ø) ⬆️
#single 42.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/interval.py 93.16% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e55af...2d3602a. Read the comment docs.

@jreback jreback merged commit b35cb1c into pandas-dev:master Jun 27, 2018
@jreback
Copy link
Contributor

jreback commented Jun 27, 2018

thanks!

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Jul 2, 2018
jorisvandenbossche pushed a commit that referenced this pull request Jul 5, 2018
@jschendel jschendel deleted the fix-ii-versionadded branch September 24, 2018 17:22
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants