DOC: Modify astype copy=False example to work across platforms #18865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff
Very minor, just changed
'int'
->'int64'
.The example as previously written does not work on Windows, since
astype('int')
converts toint32
instead ofint64
. TheSeries
constructor defaults toint64
, so on Windows theastype
ends up making a copy since the dtype changes, and thus the propagation tos1
doesn't occur.This shouldn't impact Linux or Mac, since
astype('int')
converts toint64
on those platforms, soastype('int64')
should be equivalent. I suppose this might not work for people using 32 bit distributions (?), but this should have wider coverage of potential readers of the docs, and is less confusing than using something like'intp'
.