Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR: add stacklevel to to_dict() UserWarning (#16927) #16936

Merged
merged 4 commits into from
Jul 15, 2017
Merged

ERR: add stacklevel to to_dict() UserWarning (#16927) #16936

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0985d2
ERR: add stacklevel to to_dict() UserWarning (#16927)
alanbato Jul 15, 2017
f6a7179
TST: Add warning testing to to_dict()
alanbato Jul 15, 2017
d00e6fd
Fix warning assertion on to_dict() test
alanbato Jul 15, 2017
96cc9ba
Add github issue to documentation on to_dict() warning test
alanbato Jul 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,8 @@ def to_dict(self, orient='dict', into=dict):
"""
if not self.columns.is_unique:
warnings.warn("DataFrame columns are not unique, some "
"columns will be omitted.", UserWarning)
"columns will be omitted.", UserWarning,
stacklevel=2)
# GH16122
into_c = standardize_mapping(into)
if orient.lower().startswith('d'):
Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/frame/test_convert_to.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,13 @@ def test_to_dict_errors(self, mapping):
with pytest.raises(TypeError):
df.to_dict(into=mapping)

def test_to_dict_not_unique_warning(self):
# When converting to a dict, if a column has a non-unique name it will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the issue to the beginning of that comment i.e.

gh-16927 : ...

Otherwise, this looks good to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

# be dropped, throwing a warning.
df = DataFrame([[1, 2, 3]], columns=['a', 'a', 'b'])
with tm.assert_produces_warning(UserWarning):
df.to_dict()

@pytest.mark.parametrize('tz', ['UTC', 'GMT', 'US/Eastern'])
def test_to_records_datetimeindex_with_tz(self, tz):
# GH13937
Expand Down