Drop support for NaN categories in Categorical #15806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
categories-nan-drop
branch
from
7d9f5ec to
b6a5395
Compare
jreback
added
Categorical
gfyoung
force-pushed
the
categories-nan-drop
branch
2 times, most recently
from
84fc041 to
671d0bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #15806 +/- ##
==========================================
- Coverage 91.01% 90.97% -0.04%
==========================================
Files 143 143
Lines 49387 49386 -1
==========================================
- Hits 44948 44930 -18
- Misses 4439 4456 +17
Continue to review full report at Codecov.
|
jreback
reviewed
Mar 26, 2017
pandas/tests/test_categorical.py
Outdated
| self.assertTrue(is_float_dtype(cat.categories)) | ||
|
|
||
| # Cannot have NaN in categories | ||
| def f(): |
There was a problem hiding this comment.
can you add a test for NaT as well, and FYI, you can use pytest syntax
with pytest.raises(ValueError):
....
This was referenced Mar 26, 2017
|
xref #13648 testing with |
gfyoung
force-pushed
the
categories-nan-drop
branch
from
671d0bc to
f2bdd51
Compare
Deprecated in 0.17.0. xref pandas-devgh-10748 xref pandas-devgh-13648
gfyoung
force-pushed
the
categories-nan-drop
branch
from
f2bdd51 to
4dce349
Compare
|
thanks! |
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Deprecated in 0.17.0. xref pandas-dev#10748 xref pandas-dev#13648 Author: Jeff Reback <jeff@reback.net> Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#15806 from gfyoung/categories-nan-drop and squashes the following commits: 318175b [Jeff Reback] TST: test pd.NaT with correct dtype 4dce349 [gfyoung] Drop support for NaN categories in Categorical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in 0.17.0.
xref #10748
xref #13648