Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: EA._pad_or_backfill not having a limit_area argument #56729

Open
rhshadrach opened this issue Jan 4, 2024 · 0 comments
Open

DEPR: EA._pad_or_backfill not having a limit_area argument #56729

rhshadrach opened this issue Jan 4, 2024 · 0 comments
Assignees
Labels
Deprecate Functionality to remove in pandas ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments

@rhshadrach
Copy link
Member

Ref: #56616

Currently we allow EAs to have _pad_or_backfill methods that do not accept a limit_area argument, and will only raise if e.g. Series.ffill is called with limit_area specified as either "inside" or "outside". We should deprecate this behavior, informing EA authors that override this method they need to add such an argument. The current plan:

  • Add a DeprecationWarning in 3.1
  • Switch to FutureWarning in 3.2
  • Enforce the deprecation in 4.0
@rhshadrach rhshadrach added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Deprecate Functionality to remove in pandas ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 4, 2024
@rhshadrach rhshadrach self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

No branches or pull requests

1 participant