Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: is_decimal, is_interval #55264

Closed
jbrockmendel opened this issue Sep 24, 2023 · 3 comments · Fixed by #56038
Closed

DEPR: is_decimal, is_interval #55264

jbrockmendel opened this issue Sep 24, 2023 · 3 comments · Fixed by #56038
Assignees
@Cappuchinoo
Labels
Deprecate Functionality to remove in pandas Needs Discussion Requires discussion from core team before further action

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Sep 24, 2023 •
edited
Loading

These are aliases for isinstance checks, don't seem necessary.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member Deprecate Functionality to remove in pandas Needs Discussion Requires discussion from core team before further action labels Sep 24, 2023
@lithomas1 lithomas1 removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 24, 2023
@Cappuchinoo
Copy link

Hey, I'm a new contributor to pandas, and this seems to be a pretty simple issue to take on. I'll wait for the core team discussion to start working on it but for now I'll take it if that's ok.

@Cappuchinoo
Copy link

take

@Cappuchinoo
Copy link

So I've been trying to figure this issue out today but I've been having a hard time. Hasn't this deprecation already been done? is_interval already has a warning saying it has been deprecated since version 2.0.0, and is_decimal isn't being defined in the file is_interval is (pandas\core\indexes\base.py). I'm still new here, so am I missing something?

@jbrockmendel jbrockmendel mentioned this issue Nov 18, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cappuchinoo Cappuchinoo

Labels
Deprecate Functionality to remove in pandas Needs Discussion Requires discussion from core team before further action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: is_period, is_interval jbrockmendel/pandas
3 participants
@jbrockmendel @lithomas1 @Cappuchinoo