Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: IndexEngine.get_indexer_with_fill #43388

Closed
twoertwein opened this issue Sep 3, 2021 · 0 comments · Fixed by #43828
Closed

TYP: IndexEngine.get_indexer_with_fill #43388

twoertwein opened this issue Sep 3, 2021 · 0 comments · Fixed by #43828
Labels
Typing type annotations, mypy/pyright type checking
Milestone
1.4

Comments

@twoertwein
Copy link
Member

pandas/core/indexes/base.py:3696: error: "IndexEngine" has no attribute "get_indexer_with_fill" [attr-defined]

Is this code intended to be reached only by certain sub-classes of IndexEngine that have get_indexer_with_fill?

I'm not sure how this is related to cache_readonly = property but it was found that way.
@twoertwein twoertwein added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 3, 2021
@twoertwein twoertwein mentioned this issue Sep 3, 2021
Closed
3 tasks
@simonjayhawkins simonjayhawkins added Typing type annotations, mypy/pyright type checking and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 4, 2021
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Sep 4, 2021
@twoertwein twoertwein mentioned this issue Oct 1, 2021
Merged
4 tasks
@simonjayhawkins simonjayhawkins modified the milestones: Contributions Welcome, 1.4 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

TYP: enable disallow_untyped_decorators
2 participants
@twoertwein @simonjayhawkins