Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple filters/segments for google analytics integrations #3505

Closed
changhiskhan opened this issue May 1, 2013 · 13 comments
Closed

multiple filters/segments for google analytics integrations #3505

changhiskhan opened this issue May 1, 2013 · 13 comments

Comments

@changhiskhan
Copy link
Contributor

Right now being passed into underlying google api as a list of string. Need to investigate how to specify AND vs OR

@jreback
Copy link
Contributor

jreback commented May 1, 2013

FYI this is also issue with specifying search expressions in HDFStore

need a mini boolean language to specify things like this

@jcbozonier
Copy link
Contributor

I am running into this issue right now. Any known workarounds? At least being able to specify the string myself would help a bunch.

@sk8asd123
Copy link

I'm also wondering if there's a way to just pass the raw string. Maybe access format_query directly? I'd like to be able to follow the Google Analytics filter logic as documented here: https://developers.google.com/analytics/devguides/reporting/core/v3/reference

@jreback
Copy link
Contributor

jreback commented Sep 18, 2013

@cpcloud this could be a backend like query-language for HDFStore is now (but would prob take some work)

@cpcloud
Copy link
Member

cpcloud commented Sep 18, 2013

@jreback looks interesting ... i'll take a look

@jreback
Copy link
Contributor

jreback commented Sep 18, 2013

@cpcloud its like SQL parsing, sort of

@cpcloud
Copy link
Member

cpcloud commented Sep 18, 2013

just looks like and -> ;, or -> ,

@cpcloud
Copy link
Member

cpcloud commented Sep 18, 2013

FYI the only parsing needed here is to search for the query type name e.g., filter, start-date, etc. and then build up a dict by splitting each query type on its = character...

just wanted to point that out for any first time contributors or anyone else interested in implementing this.

@manugarri
Copy link

Just submitted a PR that fixes this #8806

It's my first one, so I'm not sure i followed the proper procedure.

I have been using this modification for a while on my job and I thought it would be good to contribute :)

@DeliciousHair
Copy link

I have made a fix for this as well if anyone is interested, the filter syntax now works as:

filters = ['browser=~Firefox' , 'or', 'browser=~Chrome', 'and', 'language!~^en.*']

which is more in line with the rest of the module behaviour in that it doesn't require select useage of the ga: prefix. Not sure how to post it here though...

@jreback
Copy link
Contributor

jreback commented Nov 19, 2014

@DeliciousHair
Copy link

Ah, easy! I'll do that a little later today.

@jreback
Copy link
Contributor

jreback commented Oct 14, 2015

closing as deprecating ga in #11308

@jreback jreback closed this as completed Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants