-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple filters/segments for google analytics integrations #3505
Comments
FYI this is also issue with specifying search expressions in HDFStore need a mini boolean language to specify things like this |
I am running into this issue right now. Any known workarounds? At least being able to specify the string myself would help a bunch. |
I'm also wondering if there's a way to just pass the raw string. Maybe access format_query directly? I'd like to be able to follow the Google Analytics filter logic as documented here: https://developers.google.com/analytics/devguides/reporting/core/v3/reference |
@cpcloud this could be a backend like query-language for HDFStore is now (but would prob take some work) |
@jreback looks interesting ... i'll take a look |
@cpcloud its like SQL parsing, sort of |
just looks like |
FYI the only parsing needed here is to search for the query type name e.g., just wanted to point that out for any first time contributors or anyone else interested in implementing this. |
Just submitted a PR that fixes this #8806 It's my first one, so I'm not sure i followed the proper procedure. I have been using this modification for a while on my job and I thought it would be good to contribute :) |
I have made a fix for this as well if anyone is interested, the filter syntax now works as:
which is more in line with the rest of the module behaviour in that it doesn't require select useage of the |
Ah, easy! I'll do that a little later today. |
closing as deprecating ga in #11308 |
Right now being passed into underlying google api as a list of string. Need to investigate how to specify AND vs OR
The text was updated successfully, but these errors were encountered: