Skip to content

Commit fb95732

Browse files
committed
revert unrelated test fix
1 parent a66afa0 commit fb95732

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

pandas/tests/indexing/test_iloc.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -865,21 +865,11 @@ def test_series_indexing_zerodim_np_array(self):
865865
result = s.iloc[np.array(0)]
866866
assert result == 1
867867

868-
def test_iloc_setitem_categorical_updates_inplace(
869-
self, using_array_manager, request
870-
):
871-
# GH#35417
868+
@pytest.mark.xfail(reason="https://github.com/pandas-dev/pandas/issues/33457")
869+
def test_iloc_setitem_categorical_updates_inplace(self):
872870
# Mixed dtype ensures we go through take_split_path in setitem_with_indexer
873-
if using_array_manager:
874-
mark = pytest.mark.xfail(
875-
reason="https://github.com/pandas-dev/pandas/issues/33457"
876-
)
877-
request.node.add_marker(mark)
878-
879871
cat = Categorical(["A", "B", "C"])
880-
df = DataFrame({1: cat, 2: [1, 2, 3]}, copy=False)
881-
blk = df._mgr.blocks[1]
882-
assert blk.values is cat
872+
df = DataFrame({1: cat, 2: [1, 2, 3]})
883873

884874
# This should modify our original values in-place
885875
df.iloc[:, 0] = cat[::-1]

0 commit comments

Comments
 (0)