move methods tests, elementwise rounding

Author: andrewgsavage

pandas/tests/extension/base/__init__.py

@@ -53,7 +53,6 @@ class TestMyDtype(BaseDtypeTests):
     BaseArithmeticOpsTests,
     BaseComparisonOpsTests,
     BaseOpsUtil,
-    BaseRoundingTests,
     BaseUnaryOpsTests,
 )
 from pandas.tests.extension.base.printing import BasePrintingTests
@@ -87,7 +86,6 @@ class ExtensionTests(
     BaseArithmeticOpsTests,
     BaseComparisonOpsTests,
     BaseUnaryOpsTests,
-    BaseRoundingTests,
     BasePrintingTests,
     BaseReduceTests,
     BaseReshapingTests,

pandas/tests/extension/base/methods.py

@@ -698,3 +698,10 @@ def test_equals(self, data, na_value, as_series, box):
     def test_equals_same_data_different_object(self, data):
         # https://github.com/pandas-dev/pandas/issues/34660
         assert pd.Series(data).equals(pd.Series(data))
+
+    def test_round(self, data):
+        if not data.dtype._is_numeric:
+            pytest.skip("Round is only valid for numeric dtypes")
+        result = pd.Series(data).round()
+        expected = pd.Series([np.round(element) if pd.notna(element) else element for element in data], dtype=data.dtype)
+        tm.assert_series_equal(result, expected)

pandas/tests/extension/base/ops.py

@@ -263,10 +263,3 @@ def test_unary_ufunc_dunder_equivalence(self, data, ufunc):
         else:
             alt = ufunc(data)
             tm.assert_extension_array_equal(result, alt)
-
-
-class BaseRoundingTests:
-    def test_round(self, data):
-        result = pd.Series(data).round()
-        expected = pd.Series(np.round(data), dtype=data.dtype)
-        tm.assert_series_equal(result, expected)

pandas/tests/extension/test_arrow.py

@@ -1011,6 +1011,19 @@ def _get_arith_xfail_marker(self, opname, pa_dtype):
             )
 
         return mark
+        
+    def test_round(self, data, request):
+        mark = pytest.mark.xfail(
+            # raises=pa.ArrowInvalid,
+            reason="ArrowArray.round converts dtype to double",
+        )
+        if pa.types.is_float32(data.dtype.pyarrow_dtype) or pa.types.is_float64(
+            data.dtype.pyarrow_dtype
+        ):
+            mark = None
+        if mark is not None:
+            request.node.add_marker(mark)
+        super().test_round(data)
 
     def test_arith_series_with_scalar(self, data, all_arithmetic_operators, request):
         pa_dtype = data.dtype.pyarrow_dtype

pandas/tests/extension/test_interval.py

@@ -96,7 +96,7 @@ def test_invert(self, data):
         super().test_invert(data)
 
     @pytest.mark.xfail(
-        reason="IntervalArray.round is not implemented."
+        reason="Round is not valid for IntervalArray."
     )
     def test_round(self, data):
         super().test_round(data)

pandas/tests/extension/test_masked.py

@@ -358,15 +358,15 @@ def test_invert(self, data, request):
             )
             request.node.add_marker(mark)
         super().test_invert(data)
+        
+    def test_round(self, data, request):
+        if data.dtype == "boolean":
+            mark = pytest.mark.xfail(reason="Cannot round boolean dtype")
+            request.node.add_marker(mark)
+        super().test_round(data)
 
 
 class Test2DCompat(base.Dim2CompatTests):
     pass
 
 
-class TestRounding(base.BaseRoundingTests):
-    def test_round(self, data, request):
-        if data.dtype == "boolean":
-            mark = pytest.mark.xfail(reason="Cannot round boolean dtype")
-            request.node.add_marker(mark)
-        super().test_round(data)

pandas/tests/extension/test_numpy.py

@@ -270,6 +270,12 @@ def test_insert_invalid(self, data, invalid_scalar):
         # NumpyExtensionArray[object] can hold anything, so skip
         super().test_insert_invalid(data, invalid_scalar)
 
+    @pytest.mark.xfail(
+        reason="NumpyExtensionArray.round is not implemented."
+    )
+    def test_round(self, data):
+        super().test_round(data)
+
 
 class TestArithmetics(BaseNumPyTests, base.BaseArithmeticOpsTests):
     divmod_exc = None

pandas/tests/extension/test_sparse.py

@@ -346,6 +346,12 @@ def test_map_raises(self, data, na_action):
         with pytest.raises(ValueError, match=msg):
             data.map(lambda x: np.nan, na_action=na_action)
 
+    @pytest.mark.xfail(
+        reason="SpareArray.round not implemented."
+    )
+    def test_round(self, data):
+        super().test_round(data)
+
 
 class TestCasting(BaseSparseTests, base.BaseCastingTests):
     @pytest.mark.xfail(raises=TypeError, reason="no sparse StringDtype")