Skip to content

Commit 844f59a

Browse files
committed
fixup: Remove assert_produces_warning in tests because not raised???
1 parent 1498166 commit 844f59a

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

pandas/tests/sparse/test_frame.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1535,7 +1535,7 @@ def test_quantile_multi(self):
15351535
tm.assert_sp_frame_equal(result, sparse_expected)
15361536

15371537

1538-
def _test_assignment(kind, indexer, key=None, expect_warning=True):
1538+
def _test_assignment(kind, indexer, key=None):
15391539
arr = np.array([[1, nan],
15401540
[nan, 1]])
15411541
df = DataFrame(arr, copy=True)
@@ -1547,11 +1547,7 @@ def get_indexer(df):
15471547
if key is None:
15481548
key = pd.isnull(sdf).to_sparse()
15491549

1550-
if expect_warning:
1551-
with tm.assert_produces_warning(PerformanceWarning):
1552-
get_indexer(sdf)[key] = 2
1553-
else:
1554-
get_indexer(sdf)[key] = 2
1550+
get_indexer(sdf)[key] = 2
15551551

15561552
get_indexer(df)[key] = 2
15571553
res = df.to_sparse(kind=kind)
@@ -1584,5 +1580,4 @@ def test_frame_assignment_setitem(spindex_kind, key):
15841580
@pytest.mark.parametrize('indexer', ['loc', 'at'])
15851581
@pytest.mark.parametrize('key', [3])
15861582
def test_frame_assignment_extend_index(spindex_kind, indexer, key):
1587-
_test_assignment(spindex_kind, indexer, key,
1588-
expect_warning=indexer == 'at')
1583+
_test_assignment(spindex_kind, indexer, key)

pandas/tests/sparse/test_series.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1559,7 +1559,6 @@ def test_series_assignment(kind, indexer, key):
15591559

15601560
ss_setitem = getattr(ss, indexer) if indexer else ss
15611561

1562-
with tm.assert_produces_warning(PerformanceWarning):
1563-
ss_setitem[key] = 1
1562+
ss_setitem[key] = 1
15641563

15651564
tm.assert_sp_series_equal(ss, res)

0 commit comments

Comments
 (0)