Skip to content

Commit 65e7ca6

Browse files
committed
Adding documentation
1 parent 91b15ab commit 65e7ca6

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

doc/source/computation.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,10 @@ accept the following arguments:
250250
result is NA)
251251
- ``center``: boolean, whether to set the labels at the center (default is False)
252252

253+
.. note::
254+
255+
The ``.min()`` and ``.max()`` will by default return the result as a float. For integer inputs, integer outputs can be obtained by passing ``as_float``=False
256+
253257
.. warning::
254258
255259
The ``freq`` and ``how`` arguments were in the API prior to 0.18.0 changes. These are deprecated in the new API. You can simply resample the input prior to creating a window function.

doc/source/whatsnew/v0.18.0.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,6 +871,7 @@ Other API Changes
871871

872872
- More helpful error message when constructing a ``DataFrame`` with empty data but with indices (:issue:`8020`)
873873

874+
- ``Rolling.min`` and ``Rolling.max`` now take an as_float argument, that when False, will cause those functions to return output that has the same value as the input type. This is
874875

875876
.. _whatsnew_0180.deprecations:
876877

@@ -1123,3 +1124,4 @@ Bug Fixes
11231124
- Bug in ``DataFrame.apply`` in which reduction was not being prevented for cases in which ``dtype`` was not a numpy dtype (:issue:`12244`)
11241125
- Bug when initializing categorical series with a scalar value. (:issue:`12336`)
11251126
- Bug when specifying a UTC ``DatetimeIndex`` by setting ``utc=True`` in ``.to_datetime`` (:issue:`11934`)
1127+
- Bug in ``.rolling.min`` and ``.rolling.max`` where passing columns of type float32 raised a Value error (:issue:`12373`)

0 commit comments

Comments
 (0)