BUG: raw_locales unreachable in util.testing.get_locales

Author: davidastephens

pandas/tests/test_util.py

@@ -79,6 +79,13 @@ def test_warning(self):
         with tm.assert_produces_warning(FutureWarning):
             self.assertNotAlmostEquals(1, 2)
 
+    def test_locale(self):
+        #GH9744
+        locales = pandas.util.testing.get_locales()
+        raw_locales = pandas.util.testing._default_locale_getter()
+        print (raw_locales)
+        print (locales)
+        self.assertTrue(len(locales) >= 1)
 
 def test_rands():
     r = tm.rands(10)

pandas/util/testing.py

@@ -331,19 +331,21 @@ def get_locales(prefix=None, normalize=True,
         # raw_locales is "\n" seperated list of locales
         # it may contain non-decodable parts, so split
         # extract what we can and then rejoin.
-        raw_locales = []
+        raw_locales = raw_locales.split(b'\n')
+        out_locales = []
         for x in raw_locales:
-            try:
-                raw_locales.append(str(x, encoding=pd.options.display.encoding))
-            except:
-                pass
+            if compat.PY3:
+                out_locales.append(str(x, encoding=pd.options.display.encoding))
+            else:
+                out_locales.append(str(x))
+
     except TypeError:
         pass
 
     if prefix is None:
-        return _valid_locales(raw_locales, normalize)
+        return _valid_locales(out_locales, normalize)
 
-    found = re.compile('%s.*' % prefix).findall('\n'.join(raw_locales))
+    found = re.compile('%s.*' % prefix).findall('\n'.join(out_locales))
     return _valid_locales(found, normalize)