Skip to content

Commit 45c8c4a

Browse files
committed
fix period-out; default to None for compat with categorical/sparse.
1 parent b5273f8 commit 45c8c4a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pandas/core/generic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3383,7 +3383,7 @@ def convert_objects(self, convert_dates=True, convert_numeric=False,
33833383

33843384
@Appender(_shared_docs['fillna'] % _shared_doc_kwargs)
33853385
def fillna(self, value=None, method=None, axis=None, inplace=False,
3386-
limit=None, downcast=None, errors='coerce'):
3386+
limit=None, downcast=None, errors=None):
33873387
inplace = validate_bool_kwarg(inplace, 'inplace')
33883388

33893389
if not missing.maybe_fill(self, value, errors):

pandas/core/missing.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -630,11 +630,10 @@ def maybe_fill(obj, value, errors):
630630
"""
631631
from pandas import Series
632632
if isinstance(obj, Series):
633-
if errors == 'coerce':
633+
if errors is None or errors == 'coerce':
634634
return True
635635
else:
636-
is_period = is_period_arraylike(obj)
637-
if not valid_fill_value(value, obj.dtype, is_period=is_period):
636+
if not valid_fill_value(value, obj.dtype):
638637
if errors == 'raise':
639638
raise TypeError('"value" parameter must be compatible '
640639
'with the {0} dtype, but you passed a '

0 commit comments

Comments
 (0)