BUG: String indexing against object dtype may raise AttributeError (#…

…14424)

doc/source/whatsnew/v0.19.1.txt

@@ -40,6 +40,7 @@ Bug Fixes
 
 
 
+- Bug in string indexing against data with ``object`` ``Index`` may raise ``AttributeError`` (:issue:`14424`)
 
 
 

pandas/indexes/base.py

@@ -2966,6 +2966,11 @@ def _wrap_joined_index(self, joined, other):
         name = self.name if self.name == other.name else None
         return Index(joined, name=name)
 
+    def _get_string_slice(self, key, use_lhs=True, use_rhs=True):
+        # this is for partial string indexing,
+        # overridden in DatetimeIndex, TimedeltaIndex and PeriodIndex
+        raise NotImplementedError
+
     def slice_indexer(self, start=None, end=None, step=None, kind=None):
         """
         For an ordered Index, compute the slice indexer for input labels and

pandas/tests/indexing/test_indexing.py

@@ -3613,6 +3613,27 @@ def test_iloc_non_unique_indexing(self):
         result = df2.loc[idx]
         tm.assert_frame_equal(result, expected, check_index_type=False)
 
+    def test_string_slice(self):
+        # GH 14424
+        # string indexing against datetimelike with object
+        # dtype should properly raises KeyError
+        df = pd.DataFrame([1], pd.Index([pd.Timestamp('2011-01-01')],
+                                        dtype=object))
+        self.assertTrue(df.index.is_all_dates)
+        with tm.assertRaises(KeyError):
+            df['2011']
+
+        with tm.assertRaises(KeyError):
+            df.loc['2011', 0]
+
+        df = pd.DataFrame()
+        self.assertFalse(df.index.is_all_dates)
+        with tm.assertRaises(KeyError):
+            df['2011']
+
+        with tm.assertRaises(KeyError):
+            df.loc['2011', 0]
+
     def test_mi_access(self):
 
         # GH 4145