Review inplace parameter

[crusaderky]

Closes #44

[Dr-Irv]

This generally looks good, but you have a testing failure. Thanks for including those tests along with the stub changes.

For each of the new tests you added, can you add a reference to the GH issue, via a comment like this:

def test_types_replace() -> None:
    # GH 44
    s = pd.Series([1, 2, 3])
    res1: pd.Series = s.replace(1, 2)
    res2: pd.Series = s.replace(1, 2, inplace=False)
    res3: None = s.replace(1, 2, inplace=True)

[Dr-Irv]

CI is failing here. Should be pd.DataFrame

[crusaderky]

Fixed failing test.

For each of the new tests you added, can you add a reference to the GH issue

Not sure I understand the benefit. The issue doesn't add anything useful to understanding the test; the test performs basic coverage of the methods.

[twoertwein]

I know most tests do not yet use typing_extensions.assert_type. If you want, you could re-write these new tests to use assert_type(s.sort_index(), pd.Series).

[crusaderky]

done

[Dr-Irv]

Fixed failing test.

For each of the new tests you added, can you add a reference to the GH issue

Not sure I understand the benefit. The issue doesn't add anything useful to understanding the test; the test performs basic coverage of the methods.

It allows us to track why we added the test, in case something comes up in the future. It's a standard practice we use in the pandas project.

[crusaderky]

It allows us to track why we added the test, in case something comes up in the future. It's a standard practice we use in the pandas project.

done

[Dr-Irv]

Thanks @crusaderky