Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit_area argument is currently missing for the frame.pyi #987

Closed
AY1uZwIcJzKhaGywovQP opened this issue Aug 27, 2024 · 2 comments · Fixed by #1028
Closed

limit_area argument is currently missing for the frame.pyi #987

AY1uZwIcJzKhaGywovQP opened this issue Aug 27, 2024 · 2 comments · Fixed by #1028

Comments

@AY1uZwIcJzKhaGywovQP
Copy link

The new limit_area argument is missing for the ffill overloads for frame.pyi.

This was seen in VSCode (pylance)

df = pd.DataFrame({'a': [1, 2, 3], 'b': [4, 5, 6]})
df2 = df.sort_values('a')  # This infers the type correctly
df3 = df.ffill(limit=10)  # This infers the type correctly
df4 = df.ffill(limit_area='inside')  # This cannot infer the type since the `.pyi` is missing `limit_area`

When running error checking for types with standard, the error message is:
No overloads for "ffill" match the provided arguments   Argument types: (Literal['inside'])

  • OS: Windows 10
  • python version: 3.12
  • version of type checker
  • version of installed pandas-stubs: This is using the latest version of pylance but I'm not sure how to check the version of pandas-stubs used. However, I don't see the entry in the current latest commit in master
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 27, 2024

Thanks for the report. We need people to work on including changes from versions 2.0, 2.1 and 2.2. This is one of them.

PR with tests welcome.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 11, 2024

Should also cover Series.ffill() and Series.bfill()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants