Skip to content

Commit 5d41bcd

Browse files
twoertweinDr-Irv
andauthored
CI: unpin lxml and update mypy (#693)
* CI: unpin lxml and update mypy * Update pyproject.toml Co-authored-by: Irv Lustig <irv@princeton.com> --------- Co-authored-by: Irv Lustig <irv@princeton.com>
1 parent 621891b commit 5d41bcd

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ repos:
1111
hooks:
1212
- id: isort
1313
- repo: https://github.com/asottile/pyupgrade
14-
rev: v3.3.1
14+
rev: v3.4.0
1515
hooks:
1616
- id: pyupgrade
1717
types_or: [python, pyi]

pyproject.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@ python = ">=3.8"
3535
types-pytz = ">= 2022.1.1"
3636

3737
[tool.poetry.dev-dependencies]
38-
mypy = "1.2.0"
38+
mypy = "1.3.0"
39+
pandas = "2.0.1"
3940
pyarrow = ">=10.0.1"
4041
pytest = ">=7.1.2"
4142
pyright = ">= 1.1.306"
4243
poethepoet = ">=0.16.5"
4344
loguru = ">=0.6.0"
44-
pandas = "2.0.1"
4545
numpy = ">=1.24.3"
4646
typing-extensions = ">=4.4.0"
4747
matplotlib = ">=3.5.1"
@@ -50,15 +50,15 @@ black = ">=23.3.0"
5050
isort = ">=5.12.0"
5151
openpyxl = ">=3.0.10"
5252
tables = { version = ">=3.7.0" , python = "<4"} # 3.8.0 depends on blosc2 which caps python to <4
53-
lxml = { version = ">=4.7.1,<4.9.0", python = "<3.11" }
53+
lxml = ">=4.9.1"
5454
pyreadstat = ">=1.2.0"
5555
xlrd = ">=2.0.1"
5656
xlsxwriter = ">=3.0.3"
5757
pyxlsb = ">=1.0.10"
5858
odfpy = ">=1.4.1"
5959
xarray = ">=22.6.0"
6060
tabulate = ">=0.8.10"
61-
jinja2 = "^3.1"
61+
jinja2 = ">=3.1"
6262
scipy = ">=1.9.1"
6363
SQLAlchemy = ">=2.0.12"
6464
types-python-dateutil = ">=2.8.19"

tests/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
)
88
import os
99
import platform
10-
import sys
1110
from typing import (
1211
TYPE_CHECKING,
1312
Final,
@@ -23,11 +22,6 @@
2322
WINDOWS = os.name == "nt" or "cygwin" in platform.system().lower()
2423
PD_LTE_20 = Version(pd.__version__) < Version("2.0.999")
2524

26-
lxml_skip = pytest.mark.skipif(
27-
sys.version_info >= (3, 11), reason="lxml is not available for 3.11 yet"
28-
)
29-
# This is only needed temporarily due to no wheels being available for lxml on 3.11
30-
3125

3226
def check(actual: T, klass: type, dtype: type | None = None, attr: str = "left") -> T:
3327
if not isinstance(actual, klass):

tests/test_io.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@
6969
from pandas.io.sas.sas_xport import XportReader
7070
from pandas.io.stata import StataReader
7171

72-
from . import lxml_skip
73-
7472
DF = DataFrame({"a": [1, 2, 3], "b": [0.0, 0.0, 0.0]})
7573
CWD = os.path.split(os.path.abspath(__file__))[0]
7674

@@ -112,7 +110,6 @@ def test_orc_bytes():
112110
check(assert_type(DF.to_orc(index=False), bytes), bytes)
113111

114112

115-
@lxml_skip
116113
def test_xml():
117114
with ensure_clean() as path:
118115
check(assert_type(DF.to_xml(path), None), type(None))
@@ -121,7 +118,6 @@ def test_xml():
121118
check(assert_type(read_xml(f), DataFrame), DataFrame)
122119

123120

124-
@lxml_skip
125121
def test_xml_str():
126122
with ensure_clean() as path:
127123
check(assert_type(DF.to_xml(), str), str)
@@ -1170,7 +1166,6 @@ def test_read_sql_query_generator():
11701166
con.close()
11711167

11721168

1173-
@lxml_skip
11741169
def test_read_html():
11751170
check(assert_type(DF.to_html(), str), str)
11761171
with ensure_clean() as path:
@@ -1376,7 +1371,6 @@ def test_all_read_without_lxml_dtype_backend() -> None:
13761371
co1.close()
13771372

13781373

1379-
@lxml_skip
13801374
def test_read_with_lxml_dtype_backend() -> None:
13811375
with ensure_clean() as path:
13821376
check(assert_type(DF.to_html(path), None), type(None))

0 commit comments

Comments
 (0)