Skip to content

Commit d3a30c5

Browse files
committed
Mark the type classes as internal with an underscore in front
1 parent a8da619 commit d3a30c5

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/flask_sqlalchemy/extension.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030

3131

3232
# Type accepted for model_class argument
33-
FSA_MC = t.TypeVar(
34-
"FSA_MC",
33+
_FSA_MC = t.TypeVar(
34+
"_FSA_MC",
3535
bound=t.Union[
3636
Model,
3737
sa_orm.DeclarativeMeta,
@@ -42,7 +42,7 @@
4242

4343

4444
# Type returned by make_declarative_base
45-
class FSAModel(Model):
45+
class _FSAModel(Model):
4646
metadata: sa.MetaData
4747

4848

@@ -144,7 +144,7 @@ def __init__(
144144
metadata: sa.MetaData | None = None,
145145
session_options: dict[str, t.Any] | None = None,
146146
query_class: type[Query] = Query,
147-
model_class: t.Type[FSA_MC] = Model, # type: ignore[assignment]
147+
model_class: t.Type[_FSA_MC] = Model, # type: ignore[assignment]
148148
engine_options: dict[str, t.Any] | None = None,
149149
add_models_to_shell: bool = True,
150150
):
@@ -466,8 +466,8 @@ def __new__(
466466

467467
def _make_declarative_base(
468468
self,
469-
model_class: t.Type[FSA_MC],
470-
) -> t.Type[FSAModel]:
469+
model_class: t.Type[_FSA_MC],
470+
) -> t.Type[_FSAModel]:
471471
"""Create a SQLAlchemy declarative model class. The result is available as
472472
:attr:`Model`.
473473
@@ -491,7 +491,7 @@ def _make_declarative_base(
491491
.. versionchanged:: 2.3
492492
``model`` can be an already created declarative model class.
493493
"""
494-
model: t.Type[FSAModel]
494+
model: t.Type[_FSAModel]
495495
declarative_bases = [
496496
b
497497
for b in model_class.__bases__

0 commit comments

Comments
 (0)