Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing reset in isolation function #2733

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Fix missing reset in isolation function #2733

wants to merge 2 commits into from

Conversation

Tyl13
Copy link
Contributor

@Tyl13 Tyl13 commented May 22, 2024

Adds missing _compat.should_strip_ansi reset back to the original version of the function.

fixes #2732

  • Add tests that demonstrate the correct behavior of the change. Tests
    should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.

@davidism davidism modified the milestone: 8.1.8 May 22, 2024
@Tyl13 Tyl13 mentioned this pull request May 23, 2024
Closed
3 tasks
@AndreasBackx AndreasBackx force-pushed the fix-missing-reset branch 2 times, most recently from 7af7388 to 63877be Compare November 9, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyl13 @davidism