Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show envvar in error hint #2695

Closed
KotlinIsland opened this issue Mar 27, 2024 · 3 comments · Fixed by #2696
Closed

show envvar in error hint #2695

KotlinIsland opened this issue Mar 27, 2024 · 3 comments · Fixed by #2696

Comments

@KotlinIsland
Copy link
Contributor

@click.command()
@click.option('--a', required=True, envvar="b", show_envvar=True)
def f(a): ...
f()

Here I would want the error message to show the env var.

@davidism
Copy link
Member

davidism commented Mar 29, 2024

Out of curiosity, why does this and the PR start with an emoji in parentheses? That's pretty distracting, it's not clear how it's related to the request, and it's not something any other issues/PRs in the Pallets org use.

@davidism davidism changed the title (🎁) show envvar in error hint show envvar in error hint Mar 29, 2024
@KotlinIsland
Copy link
Contributor Author

KotlinIsland commented Mar 29, 2024

Because I like it. It got me banned from pre-commit (and all asottile projects) though 🤣

@davidism
Copy link
Member

Please don't use it unless a project indicates it's how things are done. Otherwise it's just noisy and annoying, exactly what was said in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants