Skip to content

fix bug found by Mrkisha when passing multiple filters to several methods #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2019
Merged

fix bug found by Mrkisha when passing multiple filters to several methods #3

merged 1 commit into from
Dec 5, 2019

Conversation

palicao
Copy link
Owner

@palicao palicao commented Dec 4, 2019

No description provided.

@palicao
Copy link
Owner Author

palicao commented Dec 4, 2019 •
edited
Loading

@Mrkisha can you please take a look? This should solve the "multiple filters" bug in the whole library

@palicao palicao self-assigned this Dec 4, 2019
Mrkisha
Mrkisha approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@Mrkisha Mrkisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested it locally. Looks good.

@palicao palicao mentioned this pull request Dec 5, 2019
Closed
@Mrkisha Mrkisha merged commit f2fec55 into master Dec 5, 2019
@Mrkisha
Copy link
Collaborator

Mrkisha commented Dec 5, 2019

@palicao Please tag and release.

@Mrkisha Mrkisha deleted the fix-multifilter-bug branch December 5, 2019 08:42
@palicao
Copy link
Owner Author

palicao commented Dec 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrkisha Mrkisha Mrkisha approved these changes

Assignees

@palicao palicao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palicao @Mrkisha