This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
fix: add support for TypeScript 4.0 #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @alan-agius4! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
alan-agius4
force-pushed
the
ts4-support
branch
3 times, most recently
from
f3cd994
to
727286e
Compare
JoshuaKGoldberg
suggested changes
Jul 25, 2020
There was a problem hiding this comment.
Thanks for sending this in @alan-agius4! The changes under src/ look good to me. Just hoping we can work around the major version change for tslib.
JoshuaKGoldberg
added
PR: waiting for author
PR: waiting for reviewer
and removed
PR: waiting for author
labels
JoshuaKGoldberg
approved these changes
Jul 25, 2020
adidahiya
suggested changes
Jul 28, 2020
alan-agius4
force-pushed
the
ts4-support
branch
2 times, most recently
from
e6baa9d
to
e45174d
Compare
adidahiya
reviewed
Jul 29, 2020
package.json
Outdated
| @@ -73,7 +73,7 @@ | |||
| "tslint-config-prettier": "^1.18.0", | |||
| "tslint-plugin-prettier": "^2.0.1", | |||
| "tslint-test-config-non-relative": "file:test/external/tslint-test-config-non-relative", | |||
| "typescript": "~3.8.2", | |||
| "typescript": "~4.0.0-dev.20200722", | |||
adidahiya
approved these changes
Jul 30, 2020
Merged
This was referenced Mar 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4941