Skip to content

Bump down required python version #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

MathieuDuponchelle
Copy link
Contributor

As discussed in #2, the test suite passes for me with python 3.4.3, so might as well not make it seem a more recent version is required :)

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @MathieuDuponchelle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@MathieuDuponchelle
Copy link
Contributor Author

For the record, I only signed the CLA because I like the name of the company :P

Copy link
Contributor

@gatesn gatesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gatesn gatesn merged commit 4681aa9 into palantir:master Apr 6, 2017
steff456 pushed a commit to steff456/spyder-pyls that referenced this pull request Aug 3, 2020
Install and use future only if python2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants