-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for const/type pairs as enums #66
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3f0629f
add enums snapshot test
6268a9a
refactor visitProject array spreads
8904bd8
add visitor for const/type ObjectLiterals
f40072a
📸 snapshot
538319c
use blueprint's Intent style with default values
393ef3e
Merge branch 'master' of github.com:palantir/documentalist into gg/co…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2018-present Palantir Techologies. | ||
* | ||
* This file contains dummy code for testing the typescript plugin. | ||
*/ | ||
|
||
/** classic typescript enum */ | ||
export enum Intent { | ||
PRIMARY = "primary", | ||
SUCCESS = "success", | ||
WARNING = "warning", | ||
DANGER = "danger", | ||
} | ||
|
||
/** const/type pair: enum & string literals */ | ||
export const IconName = { | ||
ADD: "add" as "add", | ||
REMOVE: "remove" as "remove", | ||
// tslint:disable-next-line:object-literal-sort-keys | ||
PLUS: "plus" as "plus", | ||
MINUS: "minus" as "minus", | ||
}; | ||
export type IconName = "add" | "remove" | "plus" | "minus"; | ||
|
||
/** plain old object literal, *not* an enum */ | ||
export const Literal = { | ||
LEFT: "left", | ||
RIGHT: "right", | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You move the test for the
Intent
enum toenums.ts
but you left this unioned string type here and duplicated it inenums.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i moved all the enums to a separate test but i left just the union here so we're testing a non-basic type