support for const/type pairs as enums #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use blueprint's Intent style with default valuesPreview: docs |
themadcreator
approved these changes
May 10, 2018
| Success, | ||
| Warning, | ||
| Danger, | ||
| } | ||
| export type IconName = "add" | "remove" | "plus" | "minus"; |
There was a problem hiding this comment.
You move the test for the Intent enum to enums.ts but you left this unioned string type here and duplicated it in enums.ts
There was a problem hiding this comment.
yes i moved all the enums to a separate test but i left just the union here so we're testing a non-basic type
Merge branch 'master' of github.com:palantir/documentalist into gg/const-typePreview: docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
support for the following syntax, exposed as
Kind.Enum: