Rethrow cookie parsing failure as IllegalArgumentException

[pkoenig10]

Before this PR

If a request contains more cookies than the configured maximum (200 by default), then the HttpServerExchange methods to obtain cookies will throw an IllegalStateException. This can result in false positives for internal errors monitors.

java.lang.IllegalStateException: {throwable0_message}
	at io.undertow.util.Cookies.createCookie(Cookies.java:397)
	at io.undertow.util.Cookies.parseCookie(Cookies.java:291)
	at io.undertow.util.Cookies.parseRequestCookies(Cookies.java:246)
	at io.undertow.util.Cookies.parseRequestCookies(Cookies.java:224)
	at io.undertow.util.Cookies.parseRequestCookies(Cookies.java:215)
	at io.undertow.server.HttpServerExchange.requestCookies(HttpServerExchange.java:1248)
	at io.undertow.server.HttpServerExchange.getRequestCookie(HttpServerExchange.java:1229)
	at com.palantir.conjure.java.undertow.runtime.ConjureContexts$ConjureServerRequestContext.cookie(ConjureContexts.java:85)
	...

After this PR

Catch these exceptions and re-throw them as SafeIllegalArgumentException.

[changelog-app]

Generate changelog in changelog/@unreleased

Type (Select exactly one)

• Feature (Adding new functionality)
• Improvement (Improving existing functionality)
• Fix (Fixing an issue with existing functionality)
• Break (Creating a new major version by breaking public APIs)
• Deprecation (Removing functionality in a non-breaking way)
• Migration (Automatically moving data/functionality to a new system)

Description

Throw IllegalArgumentException instead of IllegalStateException when request contains too many cookies.

Check the box to generate changelog(s)

• Generate changelog entry

[changelog-app]

✅ Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

---

📋Changelog Preview

💡 Improvements

• Throw IllegalArgumentException instead of IllegalStateException when request contains too many cookies. (#2761)

[kunalrkak]

One nit, otherwise lgtm!

[kunalrkak]

Maybe Optional#ofNullable here?

[pkoenig10]

This value should never be null in a parsed cookie.

[kunalrkak]

hmm, how is that better implied in this code block vs using ofNullable? seems like we're handling it in the same way, just more verbose

[pkoenig10]

I personally find this way easier to read. It's consistent with the code structure other places we read cookies (the files touched in this PR) and avoids the lambda allocation.

[kunalrkak]

Thanks!

[autorelease3]

Released 8.67.0