[IOCOM-2285] Call sending-func notify endpoint instead of the backend one (#317)

Author: Garma00

WebhookNotification/__tests__/handler.test.ts

@@ -15,7 +15,6 @@ import {
 import { CreatedMessageEventSenderMetadata } from "@pagopa/io-functions-commons/dist/src/models/created_message_sender_metadata";
 import { Notification } from "@pagopa/io-functions-commons/dist/src/models/notification";
 import { isTransientError } from "@pagopa/io-functions-commons/dist/src/utils/errors";
-import { PushNotificationsContentTypeEnum } from "@pagopa/io-functions-commons/dist/generated/definitions/PushNotificationsContentType";
 
 import { getWebhookNotificationHandler, sendToWebhook } from "../handler";
 
@@ -39,16 +38,6 @@ import * as TE from "fp-ts/lib/TaskEither";
 import * as O from "fp-ts/lib/Option";
 import { StandardServiceCategoryEnum } from "@pagopa/io-functions-admin-sdk/StandardServiceCategory";
 
-import { toInternalError, toNotFoundError } from "../../utils/domain-errors";
-import { UserProfileReader } from "../../readers/user-profile";
-
-import { aRetrievedProfile } from "../../__mocks__/mocks";
-
-const mockAppinsights = {
-  trackDependency: jest.fn(),
-  trackEvent: jest.fn()
-};
-
 const aFiscalCode = "FRLFRC74E04B157I" as FiscalCode;
 
 const aMessageId = "A_MESSAGE_ID" as NonEmptyString;
@@ -132,124 +121,45 @@ const aCommonMessageData = {
   senderMetadata: aSenderMetadata
 };
 
-const aRetrievedProfileWithFullPushNotificationsContentType = {
-  ...aRetrievedProfile,
-  pushNotificationsContentType: PushNotificationsContentTypeEnum.FULL
-};
-
 const mockRetrieveProcessingMessageData = jest
   .fn()
   .mockImplementation(() => TE.of(O.some(aCommonMessageData)));
 
-const userProfileReaderMock = jest.fn(
-  _ => TE.of(aRetrievedProfile) as ReturnType<UserProfileReader>
-);
-
 beforeEach(() => {
   jest.clearAllMocks();
 });
 
 describe("sendToWebhook", () => {
   it("should succeded with right parameters, with message content", async () => {
-    const expectedResponse = { message: "OK" };
-    const fetchApi = mockFetch(200, expectedResponse);
-    const notifyApiCall = getNotifyClient(fetchApi as any);
-    const ret = await sendToWebhook(
-      notifyApiCall,
-      "http://localhost/test" as HttpsUrl,
-      aMessage as any,
-      aMessageContent,
-      aSenderMetadata,
-      aRetrievedProfileWithFullPushNotificationsContentType,
-      false
-    )();
-
-    expect(fetchApi.mock.calls[0][1]).toHaveProperty("body");
-    const body = JSON.parse(fetchApi.mock.calls[0][1].body);
-    expect(body).toHaveProperty("message");
-    expect(body).toHaveProperty("sender_metadata");
-    expect(body.message).toHaveProperty("content");
-    expect(E.isRight(ret)).toBeTruthy();
-  });
-
-  it("should remove message content if the service require secure channel", async () => {
-    const expectedResponse = { message: "OK" };
-    const fetchApi = mockFetch(200, expectedResponse);
-    const notifyApiCall = getNotifyClient(fetchApi as any);
-    const ret = await sendToWebhook(
-      notifyApiCall,
-      "http://localhost/test" as HttpsUrl,
-      aMessage as any,
-      aMessageContent,
-      {
-        ...aSenderMetadata,
-        requireSecureChannels: true
-      },
-      aRetrievedProfileWithFullPushNotificationsContentType,
-      false
-    )();
-    expect(fetchApi.mock.calls[0][1]).toHaveProperty("body");
-    const body = JSON.parse(fetchApi.mock.calls[0][1].body);
-    expect(body).toHaveProperty("message");
-    expect(body).toHaveProperty("sender_metadata");
-    expect(body.message).not.toHaveProperty("content");
-    expect(E.isRight(ret)).toBeTruthy();
-  });
-
-  it("should remove message content if webhook message content is disabled", async () => {
-    const expectedResponse = { message: "OK" };
-    const fetchApi = mockFetch(200, expectedResponse);
-    const notifyApiCall = getNotifyClient(fetchApi as any);
+    const expectedResponse = {};
+    const fetchApi = mockFetch(204, expectedResponse);
+    const notifyApiCall = getNotifyClient(fetchApi as any, "aValidApiKey");
     const ret = await sendToWebhook(
       notifyApiCall,
       "http://localhost/test" as HttpsUrl,
-      aMessage as any,
-      aMessageContent,
-      aSenderMetadata,
-      aRetrievedProfileWithFullPushNotificationsContentType,
-      true
+      aMessage as any
     )();
-    expect(fetchApi.mock.calls[0][1]).toHaveProperty("body");
-    const body = JSON.parse(fetchApi.mock.calls[0][1].body);
-    expect(body).toHaveProperty("message");
-    expect(body).toHaveProperty("sender_metadata");
-    expect(body.message).not.toHaveProperty("content");
-    expect(E.isRight(ret)).toBeTruthy();
-  });
 
-  it("should remove message content if user did not allow verbose notifications", async () => {
-    const expectedResponse = { message: "OK" };
-    const fetchApi = mockFetch(200, expectedResponse);
-    const notifyApiCall = getNotifyClient(fetchApi as any);
-    const ret = await sendToWebhook(
-      notifyApiCall,
-      "http://localhost/test" as HttpsUrl,
-      aMessage as any,
-      aMessageContent,
-      aSenderMetadata,
-      aRetrievedProfile,
-      false
-    )();
     expect(fetchApi.mock.calls[0][1]).toHaveProperty("body");
     const body = JSON.parse(fetchApi.mock.calls[0][1].body);
-    expect(body).toHaveProperty("message");
-    expect(body).toHaveProperty("sender_metadata");
-    expect(body.message).not.toHaveProperty("content");
+    expect(body).toHaveProperty("fiscal_code");
+    expect(body).toHaveProperty("notification_type");
+    expect(body).toHaveProperty("message_id");
+    expect(body).toHaveProperty("webhookEndpoint");
     expect(E.isRight(ret)).toBeTruthy();
   });
 
   it("should return a transient error in case of timeout", async () => {
     const abortableFetch = AbortableFetch(agent.getHttpsFetch(process.env));
     const fetchWithTimeout = setFetchTimeout(1 as Millisecond, abortableFetch);
-    const notifyApiCall = getNotifyClient(toFetch(fetchWithTimeout));
+    const notifyApiCall = getNotifyClient(
+      toFetch(fetchWithTimeout),
+      "aValidApiKey"
+    );
     const ret = await sendToWebhook(
       notifyApiCall,
       "http://localhost/test" as HttpsUrl,
-      aMessage as any,
-      aMessageContent,
-      aSenderMetadata,
-      aRetrievedProfile,
-      false
+      aMessage as any
     )();
     expect(E.isLeft(ret)).toBeTruthy();
     if (E.isLeft(ret)) {
@@ -259,16 +169,8 @@ describe("sendToWebhook", () => {
 
   it("should return a transient error in case the webhook returns HTTP status 5xx", async () => {
     const fetchApi = mockFetch(500, { status: 500 });
-    const notifyApiCall = getNotifyClient(fetchApi as any);
-    const ret = await sendToWebhook(
-      notifyApiCall,
-      {} as any,
-      {} as any,
-      {} as any,
-      {} as any,
-      aRetrievedProfile,
-      false
-    )();
+    const notifyApiCall = getNotifyClient(fetchApi as any, "aValidApiKey");
+    const ret = await sendToWebhook(notifyApiCall, {} as any, {} as any)();
     expect(fetchApi).toHaveBeenCalledTimes(1);
     expect(E.isLeft(ret)).toBeTruthy();
     if (E.isLeft(ret)) {
@@ -278,16 +180,8 @@ describe("sendToWebhook", () => {
 
   it("should return a permanent error in case the webhook returns HTTP status 4xx", async () => {
     const fetchApi = mockFetch(401, { status: 401 });
-    const notifyApiCall = getNotifyClient(fetchApi as any);
-    const ret = await sendToWebhook(
-      notifyApiCall,
-      {} as any,
-      {} as any,
-      {} as any,
-      {} as any,
-      aRetrievedProfile,
-      false
-    )();
+    const notifyApiCall = getNotifyClient(fetchApi as any, "aValidApiKey");
+    const ret = await sendToWebhook(notifyApiCall, {} as any, {} as any)();
     expect(fetchApi).toHaveBeenCalledTimes(1);
     expect(E.isLeft(ret)).toBeTruthy();
     if (E.isLeft(ret)) {
@@ -310,8 +204,7 @@ describe("handler", () => {
         notificationModelMock as any,
         {} as any,
         mockRetrieveProcessingMessageData,
-        userProfileReaderMock,
-        false
+        "https://example.com" as HttpsUrl
       )(mockContext, JSON.stringify(aNotificationEvent))
     ).rejects.toThrow();
   });
@@ -326,77 +219,7 @@ describe("handler", () => {
         notificationModelMock as any,
         {} as any,
         mockRetrieveProcessingMessageData,
-        userProfileReaderMock,
-        false
-      )(mockContext, JSON.stringify(aNotificationEvent))
-    ).rejects.toThrow();
-  });
-
-  it("should return a transient error when an error occurred retrieving user profile", async () => {
-    const notificationModelMock = {
-      find: jest.fn(() => TE.of(O.some(aNotification))),
-      update: jest.fn(() => TE.of(O.some(aNotification)))
-    };
-
-    const notifyCallApiMock = jest
-      .fn()
-      .mockReturnValue(Promise.resolve(E.right({ status: 200 })));
-
-    mockRetrieveProcessingMessageData.mockImplementationOnce(() =>
-      TE.of(O.some({ ...aCommonMessageData, content: aMessageContent }))
-    );
-
-    userProfileReaderMock.mockImplementationOnce(() =>
-      TE.left(
-        toInternalError(
-          "an Error" as NonEmptyString,
-          "an Error detail" as NonEmptyString
-        )
-      )
-    );
-
-    await expect(
-      getWebhookNotificationHandler(
-        notificationModelMock as any,
-        notifyCallApiMock as any,
-        mockRetrieveProcessingMessageData,
-        userProfileReaderMock,
-        false
-      )(mockContext, JSON.stringify(aNotificationEvent))
-    ).rejects.toThrow();
-  });
-
-  it("should return a transient error when user profile has not been found", async () => {
-    const notificationModelMock = {
-      find: jest.fn(() => TE.of(O.some(aNotification))),
-      update: jest.fn(() => TE.of(O.some(aNotification)))
-    };
-
-    const notifyCallApiMock = jest
-      .fn()
-      .mockReturnValue(Promise.resolve(E.right({ status: 200 })));
-
-    mockRetrieveProcessingMessageData.mockImplementationOnce(() =>
-      TE.of(O.some({ ...aCommonMessageData, content: aMessageContent }))
-    );
-
-    userProfileReaderMock.mockImplementationOnce(() =>
-      TE.left(
-        toNotFoundError(
-          "an Error" as NonEmptyString,
-          "an Error detail" as NonEmptyString,
-          "profile" as NonEmptyString
-        )
-      )
-    );
-
-    await expect(
-      getWebhookNotificationHandler(
-        notificationModelMock as any,
-        notifyCallApiMock as any,
-        mockRetrieveProcessingMessageData,
-        userProfileReaderMock,
-        false
+        "https://example.com" as HttpsUrl
       )(mockContext, JSON.stringify(aNotificationEvent))
     ).rejects.toThrow();
   });
@@ -411,8 +234,7 @@ describe("handler", () => {
         notificationModelMock as any,
         {} as any,
         mockRetrieveProcessingMessageData,
-        userProfileReaderMock,
-        false
+        "https://example.com" as HttpsUrl
       )(mockContext, JSON.stringify(aNotificationEvent))
     ).resolves.toEqual({ kind: "FAILURE", reason: "DECODE_ERROR" });
   });
@@ -425,7 +247,7 @@ describe("handler", () => {
 
     const notifyCallApiMock = jest
       .fn()
-      .mockReturnValue(Promise.resolve(E.right({ status: 200 })));
+      .mockReturnValue(Promise.resolve(E.right({ status: 204 })));
 
     mockRetrieveProcessingMessageData.mockImplementationOnce(() =>
       TE.of(O.some({ ...aCommonMessageData, content: aMessageContent }))
@@ -435,8 +257,7 @@ describe("handler", () => {
       notificationModelMock as any,
       notifyCallApiMock as any,
       mockRetrieveProcessingMessageData,
-      userProfileReaderMock,
-      false
+      "https://example.com" as HttpsUrl
     )(mockContext, JSON.stringify(aNotificationEvent));
 
     expect(result).toEqual({
@@ -450,7 +271,7 @@ describe("handler", () => {
 
     const notifyCallApiMock = jest
       .fn()
-      .mockReturnValue(Promise.resolve(E.right({ status: 200 })));
+      .mockReturnValue(Promise.resolve(E.right({ status: 204 })));
 
     const aLongMessageContent = {
       markdown: aMessageBodyMarkdown,
@@ -470,8 +291,7 @@ describe("handler", () => {
       notificationModelMock as any,
       notifyCallApiMock,
       mockRetrieveProcessingMessageData,
-      userProfileReaderMock,
-      false
+      "https://example.com" as HttpsUrl
     )(mockContext, JSON.stringify(aNotificationEvent));
 
     expect(result).toEqual({
@@ -499,8 +319,7 @@ describe("handler", () => {
         notificationModelMock as any,
         notifyCallApiMock,
         mockRetrieveProcessingMessageData,
-        userProfileReaderMock,
-        false
+        "https://example.com" as HttpsUrl
       )(mockContext, JSON.stringify(aNotificationEvent))
     ).resolves.toEqual({ kind: "FAILURE", reason: "SEND_TO_WEBHOOK_FAILED" });
 
@@ -528,8 +347,7 @@ describe("handler", () => {
       notificationModelMock as any,
       {} as any,
       mockRetrieveProcessingMessageData,
-      userProfileReaderMock,
-      false
+      "https://example.com" as HttpsUrl
     )(mockContext, JSON.stringify(aNotificationEvent));
 
     expect(ret).toEqual({ kind: "SUCCESS", result: "EXPIRED" });