[DEV-2823] Fix test and linting for cognito functions (#1698)

* Fix linting and remove duplicated log

* Fix test

* Add changeset

Author: MarcoPonchia

.changeset/slimy-mails-search.md

@@ -0,0 +1,5 @@
+---
+"cognito-functions": minor
+---
+
+Fix broken test

apps/cognito-functions/src/__tests__/custom-message-handler.test.ts

@@ -88,7 +88,7 @@ describe('Handler', () => {
     expect(response.emailMessage).toStrictEqual(expected);
   });
 
-  it('should throw an error on user confirmed', async () => {
+  it('should log a warning and return the event on user confirmed', async () => {
     const event = makeEvent();
     const userVerifiedEvent = {
       ...event,
@@ -102,13 +102,22 @@ describe('Handler', () => {
       },
     };
 
-    // eslint-disable-next-line functional/no-try-statements
-    try {
-      await makeHandler(env)(userVerifiedEvent);
-      fail('Should not reach this point');
-    } catch (error) {
-      expect(error).toStrictEqual(new Error('Operation not permitted'));
-    }
+    // Spy on console.warn
+    const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation();
+
+    const result = await makeHandler(env)(userVerifiedEvent);
+
+    const username = event.request.userAttributes['sub'];
+    // Verify that the warning was logged
+    expect(consoleWarnSpy).toHaveBeenCalledWith(
+      `User ${username} is confirmed and has requested to resend the email. Operation not permitted.`
+    );
+
+    // Verify that the event is returned unmodified
+    expect(result).toStrictEqual(userVerifiedEvent);
+
+    // Restore the original console.warn
+    consoleWarnSpy.mockRestore();
   });
 
   it('should reply with verification link on UpdateUserAttribute event', async () => {

apps/cognito-functions/src/custom-message-handler.ts

@@ -22,10 +22,6 @@ export const makeHandler =
     ) {
       if (cognitoUserStatus === 'CONFIRMED') {
         // eslint-disable-next-line functional/no-expression-statements
-        console.log(
-          `User ${username} is confirmed and has requested to resend the email`
-        );
-        // eslint-disable-next-line functional/no-throw-statements
         console.warn(
           `User ${username} is confirmed and has requested to resend the email. Operation not permitted.`
         );