Changes to compile with PureScript V0.15 #76
+78
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, I believe this was the thread: https://discourse.purescript.org/t/javascript-conundrum-for-es6-module-in-foreign-generic/3031 |
|
tnx, @jsparkes, I have merged Your commit in https://github.com/purescript-open-community/purescript-open-foreign-generic already published https://pursuit.purescript.org/packages/purescript-open-foreign-generic/11.0.3 (can be used by just adding will send You an invite to join https://github.com/purescript-open-community |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw your comment about this in on discourse, but since you haven't checked anything, thought I would send these changes anyway. I also added spago files. It compiles with spago, but not with bower/pulp.
The main changes are like SProxy -> Proxy, and all the other types of proxy. The extra constraint discussed on discourse is included as well.