Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem installing pact standalone ruby app from github - Proxy Blocks URL #116

Closed
guilhermecgs opened this issue Dec 26, 2019 · 7 comments

Comments

@guilhermecgs
Copy link

Hi Folks,

I am having problem downloading ruby standalone app from github URL.

The company I work for blocks github url by default using a proxy.

Can I make a PR to a setup.py that only python itself is installed (and do not try to install ruby app)?

(My plan is to install ruby app manually OR use a docker image...)

@mefellows
Copy link
Member

We have a similar facility in the JS implementation (see https://github.com/pact-foundation/pact-node/blob/master/README.md#pact-download-location).

Pact Go assumes it's on the path and checks it's installed correctly. You may need to include a check for the correct installed versions if you do this, because now the implementation can get out of sync with the dependencies.

@guilhermecgs
Copy link
Author

@mefellows : So, the work outline would be: (correct me if I am wrong)

  1. Create a option to install only the python library and do not install the ruby app (in setup.py)
  2. Create some sort of configuration to set the ruby app binaries location, just like "pact_binary_location" in JS implementation
  3. When setting this configuration, check if the correct version is installed

@mefellows
Copy link
Member

I'm not familiar with idiomatic Python ways of doing these sorts of things, but yes something like the above sounds good.

Would love @matthewbalvanz-wf to chip in as he's the core maintainer here.

@taj-p
Copy link
Contributor

taj-p commented Aug 17, 2021

Hi All, is there a workaround for this? I'm running in an environment where I can only access github through a reverse proxy :(

@mefellows
Copy link
Member

I'm not sure of a workaround, but the ideal state I think is that Python bundles the Ruby application into the package, so at install time no network is required.

This is the plan for the FFI interface.

PR's welcome!

@taj-p
Copy link
Contributor

taj-p commented Aug 17, 2021 via email

@YOU54F
Copy link
Member

YOU54F commented May 3, 2023

Thanks for the great contribution @taj-p closing this now as complete

@YOU54F YOU54F closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants