Skip to content

Commit 30c462b

Browse files
committed
Merge commit 'fa1f85fd4e37374d207e14f69984cb332c61e6dc'
2 parents f5cc823 + fa1f85f commit 30c462b

File tree

4 files changed

+4
-23
lines changed

4 files changed

+4
-23
lines changed

compatibility-suite/pact-compatibility-suite/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Set of BDD style tests to check compatibility between Pact implementations.
44
This repository contains the BDD features for verifying a Pact implementation. It requires the [Cucumber BDD](https://cucumber.io/) test tool to execute.
55

66
## Adding it to a project
7-
The easyest way to add the suite to a project to to create a compatibility-suite subdirectory and then use the Git subtree command to pull the features and fixtures.
7+
The easiest way to add the suite to a project to create a compatibility-suite subdirectory and then use the Git subtree command to pull the features and fixtures.
88
The project then needs the steps to be implemented to get the features to pass.
99

1010
Recommend project layout:

compatibility-suite/pact-compatibility-suite/features/V3/matching_rules.feature

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,27 +32,6 @@ Feature: V3 era Matching Rules
3232
Then the comparison should NOT be OK
3333
And the mismatches will contain a mismatch with error "$.one" -> "Expected 'dog' to include 'a'"
3434

35-
Scenario: Supports an include matcher (positive case)
36-
Given an expected request configured with the following:
37-
| body | matching rules |
38-
| file: basic.json | include-matcher-v3.json |
39-
And a request is received with the following:
40-
| body |
41-
| JSON: { "one": "cat", "two": "b" } |
42-
When the request is compared to the expected one
43-
Then the comparison should be OK
44-
45-
Scenario: Supports an include matcher (negative case)
46-
Given an expected request configured with the following:
47-
| body | matching rules |
48-
| file: basic.json | include-matcher-v3.json |
49-
And a request is received with the following:
50-
| body |
51-
| JSON: { "one": "dog", "two": "b" } |
52-
When the request is compared to the expected one
53-
Then the comparison should NOT be OK
54-
And the mismatches will contain a mismatch with error "$.one" -> "Expected 'dog' to include 'a'"
55-
5635
Scenario: Supports a minmax type matcher (positive case)
5736
Given an expected request configured with the following:
5837
| body | matching rules |

compatibility-suite/pact-compatibility-suite/features/V3/message_provider.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ Feature: Message provider
139139
Then the verification will NOT be successful
140140
And the verification results will contain a "Body had differences" error
141141

142+
@wip
142143
Scenario: Supports messages with body formatted for the Kafka schema registry
143144
Given a provider is started that can generate the "kafka" message with "file: kafka-body.xml"
144145
And a Pact file for "kafka":"file: kafka-expected-body.xml" is to be verified

compatibility-suite/pact-compatibility-suite/fixtures/pact-broker_c2.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,7 @@
283283
"testResults": [
284284
{
285285
"interactionId": "ID1",
286+
"interactionDescription":"ID1",
286287
"mismatches": [
287288
{
288289
"attribute": "status",
@@ -334,7 +335,7 @@
334335
}
335336
]
336337
},
337-
"$.testResults[*].interactionId": {
338+
"$.testResults.*": {
338339
"combine": "AND",
339340
"matchers": [
340341
{

0 commit comments

Comments
 (0)