Skip to content

Commit 58333ad

Browse files
committed
Applied some minor improvements
1 parent 3d11f21 commit 58333ad

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/dsff/csv.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ def from_csv(dsff, path=None, exclude=DEFAULT_EXCL):
1313
features = {}
1414
for headers in dsff['data'].rows:
1515
for header in headers:
16+
if header.value in exclude:
17+
continue
1618
features[header.value] = ""
1719
break
1820
dsff.write(features=features)
@@ -24,8 +26,8 @@ def to_csv(dsff, path=None, text=False):
2426
dsff.logger.debug(f"extracting data from DSFF to {[path,'CSV'][text]}...")
2527
with (StringIO() if text else open(path, 'w+')) as f:
2628
writer = csvmod.writer(f, delimiter=";")
27-
for cells in dsff['data'].rows:
28-
writer.writerow([dsff._DSFF__eval(c.value) for c in cells])
29+
for row in dsff.data:
30+
writer.writerow(row)
2931
if text:
3032
return f.getvalue()
3133

src/dsff/dataset.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,8 @@ def from_dataset(dsff, path=None):
1212
if not isdir(path):
1313
raise BadInputData("Not a folder")
1414
else:
15-
missing = []
16-
for f in ["data.csv", "features.json", "metadata.json"]:
17-
if not isfile(join(path, f)):
18-
missing.append(f)
19-
if len(missing) > 0:
20-
raise BadInputData("Not a valid dataset folder (missing: %s)" % ", ".join(missing))
15+
if len(missing := [f for f in ["data.csv", "features.json", "metadata.json"] if not isfile(join(path, f))]) > 0:
16+
raise BadInputData(f"Not a valid dataset folder (missing: {', '.join(missing)})")
2117
dsff.write(path)
2218

2319

0 commit comments

Comments
 (0)