Skip to content

Conversation

KyoSakuyo
Copy link

支持Github Actions 自动构建 Docker File 自动上传到 Github pkg

@vercel
Copy link

vercel bot commented Feb 1, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @pacexy on Vercel.

@pacexy first needs to authorize it.

@pacexy
Copy link
Owner

pacexy commented Mar 14, 2024

Hi @KyoSakuyo 最近准备把之前遗留的PR都合了,有什么需要帮助的吗

@pacexy pacexy requested a review from Copilot September 19, 2025 03:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub Actions support for automated Docker image building and publishing to GitHub Container Registry (ghcr.io). The changes enable continuous integration that builds Docker images on pushes to main branch and tags, then publishes them to GitHub Packages.

  • Adds GitHub Actions workflow for Docker image CI/CD
  • Updates Dockerfile to use specific pnpm version and non-frozen lockfile installation
  • Modifies .npmrc configuration to enable shameful hoisting and relax dependency constraints

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/docker-image.yml New GitHub Actions workflow for building and pushing Docker images to GitHub Container Registry
Dockerfile Updates pnpm configuration to use specific version and non-frozen lockfile installation
.npmrc Enables shameful hoisting and relaxes peer dependency constraints for Docker builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

RUN pnpm i --frozen-lockfile
RUN corepack prepare pnpm@7.26.3 --activate

RUN pnpm install --no-frozen-lockfile
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --no-frozen-lockfile in Docker builds can lead to non-reproducible builds and potential security vulnerabilities. Consider using --frozen-lockfile for production Docker images to ensure consistent dependency versions.

Suggested change
RUN pnpm install --no-frozen-lockfile
RUN pnpm install --frozen-lockfile

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants