Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when doing data propagation with a circuit in the network #444

Open
chateauferret opened this issue Sep 19, 2024 · 4 comments
Open

Comments

@chateauferret
Copy link

Qt Nodes is fine with a circuit in the network if there is no data propagation through the nodes, but if there is, it causes an infinite loop and a stack overflow which leads to a crash.

I have some code for finding such loops somewhere (from an attempt of my own years ago), I can try and adapt that. Alternatively we can start propagating the data and remember the connection that triggered it, then send the user a snotty message if we end up back where we started. That way would only find circuits in a propagating network, of course.

@YashKarpe96
Copy link

i also am in the process of starting some work on this, maybe it requires a depth-first search (or breadth-first search approach to check before accepting any new connection

@qq978358810
Copy link

Connect to dfs using topology

@YashKarpe96
Copy link

Hey @qq978358810,

Could you provide a bit more detail on which internal classes or components you'd recommend starting with for the "connect to DFS using topology" approach? Any pointers or starting ground would be really helpful as we work on incorporating this.

Appreciate your input!

@qq978358810
Copy link

qq978358810 commented Nov 2, 2024

I made some changes to the code

image
image
image
image

Hey @qq978358810, 嘿

Could you provide a bit more detail on which internal classes or components you'd recommend starting with for the "connect to DFS using topology" approach? Any pointers or starting ground would be really helpful as we work on incorporating this.您能否更详细地介绍一下,对于“使用拓扑连接到 DFS”方法,您建议从哪些内部类或组件开始?在我们努力整合这一点时,任何指示或起点都将非常有帮助。

Appreciate your input! 感谢您的意见!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants