-
Notifications
You must be signed in to change notification settings - Fork 211
Fix tests, test more, support Node 16-20 #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70b153a
to
f9cafc9
Compare
…etch` (adding `node-fetch` until Node 18)
Some build errors after updating |
I've fixed poor spelling of Fixing |
|
^ It works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I notice there are some Github Actions lint warnings for test/integration/route/task/index.js
because it doesn't like the length of those mocked URLs. I don't know how hard GA is going to go on this though as it doesn't seem to have failed the checks, just warned us about the lines in question. I leave it in your hands to decide what you want to do about it at the moment, as it's not like it's going to affect the operation of anything 😅
Thanks @hollsk for the review. Re: linter warnings, these ones seem pretty valid. I don't think the lines under test were changed by this PR, but I'll create a separate PR to separate them into different lines and quieten those nags. |
Changes
pa11y-webservice@4.2.0
request
withnode-fetch
(can move to native fetch in next major version)pa11y-lint-config
underscore
withlodash.groupby
andlodash.keys
less
anduglify
setup.js
describe.only()
pa11y-lint-config
pa11y-webservice
, so that this project can test its own stated support)npm install
withnpm ci
pa11y-webservice
to be available, rather than sleeping for 10s.nvmrc
(went with 14 because of Apple Silicon)