Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_boost which pulled in the compromised xz dependency. #4584

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Mar 31, 2024

@fruffy fruffy changed the title Fix rules_boost which pulls in the compromised xz dependency. Fix rules_boost which pulled in the compromised xz dependency. Mar 31, 2024
@fruffy fruffy changed the title Fix rules_boost which pulled in the compromised xz dependency. Update rules_boost which pulled in the compromised xz dependency. Mar 31, 2024
@fruffy fruffy marked this pull request as ready for review March 31, 2024 18:40
@asl
Copy link
Contributor

asl commented Apr 1, 2024

Looks good to me in general, though I would suggest someone who really uses bazel build to double confirm :)

@fruffy
Copy link
Collaborator Author

fruffy commented Apr 1, 2024

Looks good to me in general, though I would suggest someone who really uses bazel build to double confirm :)

We can always revert if this breaks downstream, but right now our CI is broken because https://github.com/tukaani-project/xz is quarantined.

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the same recommendation as someone else made for someone who actually uses Bazel to try this out, but understood the desire to get it in soon.

@fruffy fruffy added this pull request to the merge queue Apr 1, 2024
Merged via the queue into main with commit 3ac6162 Apr 1, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/bazel_fix branch April 1, 2024 16:19
@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants