Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf & Abseil compilation pollutes build with a lot of warnings #4523

Closed
vlstill opened this issue Mar 12, 2024 · 1 comment · Fixed by #4556
Closed

Protobuf & Abseil compilation pollutes build with a lot of warnings #4523

vlstill opened this issue Mar 12, 2024 · 1 comment · Fixed by #4556
Labels
enhancement This topic discusses an improvement to existing compiler code.

Comments

@vlstill
Copy link
Contributor

vlstill commented Mar 12, 2024

Compiling with FetchContent Abseil and Protobuf, there is a lot of warnings. In parallel build they are also interleaved with proper p4c/extensions build which makes readability even worse.

  • We should supress warnings in the builds of dependencies, they are not relevant.
  • We should make sure the abseil/protobuf include search paths are included as -isystem -- some of the warnings are coming from abseil headers included into our code.
@fruffy
Copy link
Collaborator

fruffy commented Mar 12, 2024

I have been trying to make Abseil a system include here: #4511

The problem is the overly opinionated Bazel build. We may have to patch the Abseil Bazel dependency to get things to work because I do not think the Abseil devs will fix this.

Relevant issue:
abseil/abseil-cpp#740

Edit: Someone suggested a patch which may work: abseil/abseil-cpp#1637

@fruffy fruffy added the enhancement This topic discusses an improvement to existing compiler code. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This topic discusses an improvement to existing compiler code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants